Reviewed: https://reviews.mahara.org/7411 Committed: https://git.mahara.org/mahara/mahara/commit/359f354007b26e910d3b1e758b33f21182702d01 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch: master
commit 359f354007b26e910d3b1e758b33f21182702d01 Author: Cecilia Vela Gurovic <cecili...@catalyst.net.nz> Date: Tue Jan 24 11:46:38 2017 +1300 Bug 1655456: fix shared collection not displaying Collection shared to a group was not displaying in group page and shared with me page after first page of collection was deleted. Fixed by resetting the order when deleting a view. behatnotneeded Change-Id: I096114ecf50b7a3af6d1393b387073676a984006 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1655456 Title: Sharing collection with a group not showing on group homepage list Status in Mahara: Fix Committed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: Confirmed Status in Mahara 16.10 series: Confirmed Bug description: Sometimes when a user shares a collection with a group they belong to that collection doesn't show in the list for 'Collections shared with this group' in the Group pages block. The reason for this is because the sql for the list only fetches the collection_view page with displayorder = 0 This is so it fetches the first page so can get the url for collection and also limit the results to once per collection. The problem occurs when one deletes the first page from a collection via the edit collections views page. It doesn't reset the collection views display order and so there is no displayorder = 0 A workaround for this could be to change the line in lib/view.php for get_sharedcollections_data() from AND (cv.displayorder = 0 OR cv.displayorder IS NULL) to AND (cv.displayorder = (SELECT MIN(displayorder) FROM collection_view WHERE collection = c.id) OR cv.displayorder IS NULL) where it fetches the minimum display order value Or fix up the deletion of views from collection so that the displayorder is reset correctly To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1655456/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp