Reviewed: https://reviews.mahara.org/7737 Committed: https://git.mahara.org/mahara/mahara/commit/fee994ca330cb614a084cd169e7c39f2a06b591f Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch: 17.04_STABLE
commit fee994ca330cb614a084cd169e7c39f2a06b591f Author: Robert Lyon <robe...@catalyst.net.nz> Date: Mon May 8 11:04:13 2017 +1200 Bug 1681291: Missing params for LeapImportComment::setup_relationships() When the bug 1643365 was fixed we missed a place where the setup_relationships() was called. We need to add the extra required parameters to the call behatnotneeded Change-Id: I093937073598d4ff39abfa10aa9725319a40ec55 Signed-off-by: Robert Lyon <robe...@catalyst.net.nz> (cherry picked from commit a407b3791a85b59c1a83d50216d187cc7a53905f) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1643365 Title: LeapImportArtefactPlugin warning when extending class adds parameters in method Status in Mahara: Fix Released Bug description: When trying to import a Leap2A file, the operation in successful but shows following warning for several classes: [WAR] de (artefact/resume/import/leap/lib.php:0) Declaration of LeapImportResume::import_author_data(PluginImport $importer, $persondataid) should be compatible with LeapImportArtefactPlugin::import_author_data(PluginImportLeap $importer, $persondataid) [WAR] de (artefact/plans/import/leap/lib.php:0) Declaration of LeapImportPlans::setup_relationships(SimpleXMLElement $entry, PluginImportLeap $importer) should be compatible with LeapImportArtefactPlugin::setup_relationships(SimpleXMLElement $entry, PluginImportLeap $importer, $strategy, array $otherentries) [WAR] de (artefact/annotation/import/leap/lib.php:0) Declaration of LeapImportAnnotation::setup_view_relationships(SimpleXMLElement $entry, PluginImportLeap $importer) should be compatible with LeapImportArtefactPlugin::setup_view_relationships(SimpleXMLElement $entry, PluginImportLeap $importer, $strategy, array $otherentries) [WAR] de (artefact/comment/import/leap/lib.php:0) Declaration of LeapImportComment::setup_relationships(SimpleXMLElement $entry, PluginImportLeap $importer) should be compatible with LeapImportArtefactPlugin::setup_relationships(SimpleXMLElement $entry, PluginImportLeap $importer, $strategy, array $otherentries) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1643365/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
