Reviewed: https://reviews.mahara.org/7975 Committed: https://git.mahara.org/mahara/mahara/commit/c2208ed41610fc547f69a46f4da2920583c16506 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch: 17.04_STABLE
commit c2208ed41610fc547f69a46f4da2920583c16506 Author: Pramith Dayananda <prami...@catalyst.net.nz> Date: Fri Jun 23 09:25:09 2017 +1200 Bug 1694875: Annotation field validated via JS Validation on portfolio collections Validation on smartevidence grid Behat tests added A new feature file added Change-Id: Ib5adf627f3391fb53805b0566a7c405313a3066b -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1694875 Title: Annotation field can be left empty when adding annotation Status in Mahara: Fix Committed Status in Mahara 16.10 series: In Progress Status in Mahara 17.04 series: Fix Committed Status in Mahara 17.10 series: Fix Committed Bug description: Mahara 16.10 and 17.04+ When you add an annotation block, you are supposed to be required to provide an annotation in order to say why you align your portfolio with a particular standard. The "Annotation" field (no matter whether added via the SmartEvidence map or as block) can be left empty though now when saving the block configuration. It can't be added later on. The field should not be left empty though as the annotation is a vital aspect. To replicate: 1. Add a collection with a SmartEvidence map. 2. Add an annotation via the SmartEvidence map. Expected result: You can't save the configuration dialogue without typing an annotation. Actual result: You can leave the field empty and save. 3. Add an annotation via the portfolio page. Expected result: You can't save the configuration dialogue without typing an annotation. Actual result: You can leave the field empty and save. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1694875/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp