Reviewed: https://reviews.mahara.org/7912 Committed: https://git.mahara.org/mahara/mahara/commit/ff8106115709d6f1dedcef40aff594852c675fe2 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch: master
commit ff8106115709d6f1dedcef40aff594852c675fe2 Author: Raoul Dorissen <raoul.doris...@gmail.com> Date: Wed Aug 2 09:49:23 2017 +1200 Bug 1706263: Updating db keywords to be escaped Added new keywords to be quoted when creating db queries Change-Id: I699bbbf949ab6014da515bfa9d45bd4f2310f309 behatnotneeded -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1706263 Title: Mahara17.04.2 fails to install when deployed against MariaDB v10.2.4 or higher Status in Mahara: Fix Committed Status in Mahara 17.04 series: In Progress Status in Mahara 17.10 series: Fix Committed Bug description: During the installation process the installation is halted due to an error. As a result further deploy+ent of the Mahara server is not possible. Used configuration Ubuntu 16.4LTS, Moodle 3.3.1, Mahara 17.04.2, MariaDB 10.2.6 Consulting the apache error log files gives back following information [Mon Jul 24 10:06:57.616387 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [INF] 2a (admin/upgrade.php:49) Starting Mahara installation..., referer: http://mahara.syntra-cloud.be/admin/index.php [Mon Jul 24 10:07:11.571057 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) mysqli error: [1064: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'rows BIGINT(10) NOT NULL DEFAULT 1,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571082 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) iscustom TINYINT(1) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571094 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) ' at line 3] in EXECUTE("CREATE TABLE view_layout (, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571096 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) id BIGINT(10) NOT NULL auto_increment,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571097 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) rows BIGINT(10) NOT NULL DEFAULT 1,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571099 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) iscustom TINYINT(1) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571101 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) layoutmenuorder BIGINT(10) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571102 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) CONSTRAINT PRIMARY KEY (id), referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571104 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) )ENGINE=innodb")Command was: CREATE TABLE view_layout (, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571106 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) id BIGINT(10) NOT NULL auto_increment,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571108 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) rows BIGINT(10) NOT NULL DEFAULT 1,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571109 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) iscustom TINYINT(1) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571111 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) layoutmenuorder BIGINT(10) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571112 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) CONSTRAINT PRIMARY KEY (id), referer: http://mahara.syntra-cloud.be/admin/upgrade.php Looking into file htdocs/lib/db/install.xml (line726) – table view_layout A Quick analysis of the problem indicated the following The column rows in the table view_layout is causing a problem (as of MariaDB 10.2.4 rows is now a reserved keyword (https://mariadb.com/kb/en/mariadb/reserved-words/) <TABLE NAME="view_layout"> <FIELDS> <FIELD NAME="id" TYPE="int" LENGTH="10" NOTNULL="true" SEQUENCE="true"/> <FIELD NAME="rows" TYPE="int" LENGTH="10" NOTNULL="true" DEFAULT="1"/> <FIELD NAME="iscustom" TYPE="int" LENGTH="1" NOTNULL="true" DEFAULT="0"/> <FIELD NAME="layoutmenuorder" TYPE="int" LENGTH="10" NOTNULL="true" DEFAULT="0"/> </FIELDS> <KEYS> <KEY NAME="primary" TYPE="primary" FIELDS="id"/> </KEYS> </TABLE> To hotfix the issue I´ve updated the column rows to numrows in the following files after which the installation continues as expected and Mahara functioned properly. htdocs/lib/db/install.xml (line726) rename ´rows´ column to ´numrows´ htdocs/lib/db/upgrade.php (line2407) rename ´rows´ column to ´numrows´ htdocs/lib/db/upgrade.php (line2441) rename ´rows´ column to ´numrows´ htdocs/lib/upgrade.php (line1233) rename ´rows´ column to ´numrows´ htdocs/lib/upgrade.php (line1292) rename ´rows´ column to ´numrows´ htdocs/lib/view.php (line1185) rename ´rows´ column to numrows´ htdocs/lib/view.php (line2935) rename ´rows´ column to ´numrows´ To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1706263/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
