Bug had to be reopened to fix the following issue: Kevin Dibble has posted comments on this change.
Change subject: Bug 1806524: edit page has duplicated "addblock" in html tags ...................................................................... Patch Set 1: (1 comment) https://reviews.mahara.org/#/c/9673/1/htdocs/js/views.js File htdocs/js/views.js: Line 999: $('#newblock .cancel, #newblock .deletebutton').on('mousedown keydown', function(e) { Hi team. The dialog box that appears cannot be closed by clicking the "x" at the top right anymore. To get this issue - Just click the "text" box on the side (to add a new text box to the page) to get the dialog to appear. click the "X" at the top and nothing happens. Putting this back to "#addblock .deletebutton" resolves as the delete button is outside the form. ** Changed in: mahara/19.04 Status: Fix Committed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1806524 Title: edit page has duplicated "addblock" in html tags Status in Mahara: In Progress Status in Mahara 19.04 series: In Progress Bug description: when editing a page, if we inspect the html we can see there are two elements with the id="addblock". All id's in html tags should be unique. We need to fix this either for the form that pop's up when adding a block to the page by clicking on the block menu, or fix it for the modal that contains it. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1806524/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
