Reviewed: https://reviews.mahara.org/10074 Committed: https://git.mahara.org/mahara/mahara/commit/afd9e7a726aef567921b9b275d44ac549947543e Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch: master
commit afd9e7a726aef567921b9b275d44ac549947543e Author: Robert Lyon <robe...@catalyst.net.nz> Date: Wed Jun 12 10:26:23 2019 +1200 Bug 1831689: Adjusting how we update dates on the the view access page There was a problem where we set up fields with empty date and then try to add a date to it Instead we should set up the datepicker with the date so that works out what type of date it is first so then can handle it correctly Note: if trying to use format DD/MM/YYYY it will complain that it is a non-compatible date behatnotneeded Change-Id: I401e0812dc2c4189b715033fcf7b745c52425b05 Signed-off-by: Robert Lyon <robe...@catalyst.net.nz> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1831689 Title: Datepicker doesnt work with different date formats Status in Mahara: Fix Committed Status in Mahara 19.04 series: Confirmed Status in Mahara 19.10 series: Fix Committed Bug description: When a different date format (other than the Mahara default YYYY/MM/DD HH:mm), the datepicker doesnt work. Steps to reproduce: 1. Update lang/en.utf8/langconfig.php with the following: $string['pieform_calendar_dateformat'] = '%%d/%%m/%%Y'; $string['pieform_calendar_timeformat'] = '%%l:%%M %%p'; 2. Clear site cache 3. In the Shared by Me, set 'Allow comments' = Yes 4. Enter a page to share with a group with an end date selected from outside of the current month. 5. Save and re-enter the page. Expected result: Clicking on the 'to' field opens the datepicker Actual result: the datepicker doesnt open and error messages are displayed in the console. Steps I've tried to fix: -Hard coding the new date format (DD/MM/YYYY h:mm A) into theme/raw/templates/form/viewacl.tpl:164 -Adding new code to the library as per https://github.com/tempusdominus/bootstrap-4/issues/193#issuecomment-465649868 -Removing the local from theme/raw/templates/form/viewacl.tpl:165 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1831689/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
