Reviewed: https://reviews.mahara.org/9710 Committed: https://git.mahara.org/mahara/mahara/commit/68b575088d834216157918d57f192e90da62beff Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch: master
commit 68b575088d834216157918d57f192e90da62beff Author: Robert Lyon <robe...@catalyst.net.nz> Date: Fri Apr 5 13:58:48 2019 +1300 Bug 1785985: Remove notification triggers - building a php based way to update notification read count behatnotneeded Change-Id: Ibfdb79e36460a327372b1c9da3f624d7c8210d0c Signed-off-by: Robert Lyon <robe...@catalyst.net.nz> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1785985 Title: Remove triggers from Mahara database Status in Mahara: Fix Committed Bug description: I've created a forum post to discuss this: * https://mahara.org/interaction/forum/topic.php?id=8324 Basically, my reasoning is: 1. Mahara supports two DB types - MySql and Postgres. Each DB has different syntax when it comes to creating/updating/deleting triggers. This makes it complicated to develop and maintain. 2. Mahara already has the concept of events in place. We can move the functionality of each trigger into an event. We would then have more control over the event. For example, don't action an event during an upgrade. 3. Triggers make it difficult to see what is actually happening. They are not transparent. If you weren't aware that there is a trigger on the table, it can make it difficult to track down why something is behaving in a certain way. We can start slowly by removing one at a time. It doesn't have to happen all at once. Just my thoughts. Cheers. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1785985/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp