- Code/Gerrit: https://reviews.mahara.org/#/c/10657/ patch set 8 Successfully repeated previous test steps 1 and 2 and also included the following test scenario.
Test scenario 2: running 'gulp' Preconditions: a. Current Mahara master present. b. Patch applied. Test steps: 1. Run the command 'gulp' in a Terminal session to start css monitoring. Expected result ✔ : messages will display to indicate that the css files have been complied and the 'watch' has started. 2. Using your editor of choice, select to edit a css related file: - used file mahara/theme/raw/sass/features/_comment.scss - make a change (edited line 51 'background-color: transparent;' to 'background-color: red;') - Save the change Expected result ✔ : messages will display to indicate that the css files have been complied. 3. Using your editor of choice, select to undo your css related file change then Save the change. Expected result ✔ : messages will display to indicate that the css files have been complied. 4. Ctrl-C to end css monitoring. (see attachment for Terminal output) ** Attachment added: "Bug 1855373 Update Gulp to v4" https://bugs.launchpad.net/mahara/+bug/1855373/+attachment/5329924/+files/Bug%201855373%20Update%20Gulp%20to%20v4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1855373 Title: Update gulp Status in Mahara: In Progress Bug description: A while ago we pinned Gulp to version 3.9 to prevent a problem with dependency incompatibility. We now need to upgrade Gulp to version 4 to get rid of vulnerabilities in some of its dependencies. What needs to happen: 1. Check for dependency incompatibility with Gulp 4 to see if it's still an issue. If so, can we work around it? 2. See what's involved with upgrading to Gulp 4 3. We could look at the dependencies we are including for gulp (and maybe node dependencies too, although this could be a separate issue) and confirm that they are needed in Mahara. Investigation of the above points: 1. The only dependency we have now that is incompatible with v.4 seems to be gulp-help. It doesn't look like it will cause any problems to remove it, so we should just remove it. 2. There are syntax changes that need to be made, but it looks like they can be made in the gulpfile.js, which limits the coding to be done. Assumption made: There are no wider changes necessary. 3. Not looked at at this stage. Gulp docs: https://gulpjs.com/docs/en/getting-started/quick-start 3rd party links: https://stackoverflow.com/questions/36897877/gulp-error-the-following-tasks-did-not-complete-did-you-forget-to-signal-async https://stackoverflow.com/questions/50505275/gulp4-assertionerror-task-never-defined-when-calling-or-importing-tasks https://codeburst.io/switching-to-gulp-4-0-271ae63530c0 https://coder-coder.com/gulp-4-walk-through/ To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1855373/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
