Reviewed: https://reviews.mahara.org/10805 Committed: https://git.mahara.org/mahara/mahara/commit/ab846aa74c126e82b065e19b8e2fc04e282b0282 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch: 18.10_STABLE
commit ab846aa74c126e82b065e19b8e2fc04e282b0282 Author: Lisa Seeto <lisase...@catalyst.net.nz> Date: Mon Mar 2 14:14:34 2020 +1300 Bug 1865400: Security Upgrade SimpleSAML 1.17.7 to 1.18.4 - upgraded to version 1.18.4 Change-Id: Ic76de9cef3a61bb71e056582b8dd1dc2aeb3571b Signed-off-by: Lisa Seeto <lisase...@catalyst.net.nz> (cherry picked from commit 389ce48e6e37492e28a1ccd7b24beea23ca45627) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1865400 Title: Security Upgrade SimpleSAML 1.17.7 to 1.18.4 Status in Mahara: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Bug description: From https://simplesamlphp.org: Background SimpleSAMLphp allows users to report errors and failures to the system administrators via a web form. This web form gathers some contextual information automatically, but it also allows the user to provide their email address for follow-ups and a free-text explanation of what happened. Once submitted, the report is sent as an email to the administrative email address configured in the software. Description The www/erroreport.php script allows error reports to be submitted and sent to the system administrator. Starting with SimpleSAMLphp 1.18.0, a new SimpleSAML\Utils\EMail class was introduced to handle sending emails, implemented as a wrapper of an external dependency. This new wrapper allows us to use Twig templates in order to create the email sent with an error report. Since Twig provides automatic escaping of variables, manual escaping of the free-text field in www/errorreport.php was removed to avoid double escaping. However, for those not using the new user interface yet, an email template is hardcoded into the class itself in plain PHP. Since no escaping is provided in this template, it is then possible to inject HTML inside the template by manually crafting the contents of the free-text field. Affected versions SimpleSAMLphp versions 1.18.0 to 1.18.3, both inclusive. We will need to upgrade to version 1.18.4 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1865400/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
