Reviewed:  https://reviews.mahara.org/11458
Committed: 
https://git.mahara.org/mahara/mahara/commit/2f70c9ae4511519f28c4fbb58712031aa17342ad
Submitter: Lisa Seeto (lisase...@catalyst.net.nz)
Branch:    master

commit 2f70c9ae4511519f28c4fbb58712031aa17342ad
Author: Robert Lyon <robe...@catalyst.net.nz>
Date:   Wed Nov 18 12:53:08 2020 +1300

Bug 1904636: Only call pre login hook for active auth methods

In case you are trying to use a site where an auth type has been
removed from the files and is inactive in the db you don't want it to
be called in the auth_plugins_call_pre_loginpage_hook() function

Change-Id: Ieaca8159c1004b695b6c4ce7773b6e7aff1a83f8
Signed-off-by: Robert Lyon <robe...@catalyst.net.nz>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1904636

Title:
  Only check pre-login hook if the auth method is active

Status in Mahara:
  Fix Committed
Status in Mahara 21.04 series:
  Confirmed
Status in Mahara 21.10 series:
  Fix Committed

Bug description:
  Noticed this problem when dealing with a db that had an old auth type
  in it that didn't exist on local codebase.

  When an auth method is inactive we shouldn't need to check it's
  prelogin hook

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1904636/+subscriptions

_______________________________________________
Mailing list: https://launchpad.net/~mahara-contributors
Post to     : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

Reply via email to