Reviewed: https://reviews.mahara.org/11973 Committed: https://git.mahara.org/mahara/mahara/commit/ff1230298fd6302f466170ac18d7509bdf7a8702 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch: 20.10_STABLE
commit ff1230298fd6302f466170ac18d7509bdf7a8702 Author: Mitsuhiro Yoshida <m...@mitstek.com> Date: Wed Sep 1 10:27:25 2021 +0900 Bug 1942268: Making 'Delete standard' and 'Delete standard element' button on SmartEvidence Editor translatable. Change-Id: Iffd89fee53ec9427ecaf92afc638322a8e480dbc (cherry picked from commit 206866fe6b69592c85284958f554affe2ac45167) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1942268 Title: Making 'Delete standard' and 'Delete standard element' button on SmartEvidence Editor translatable. Status in Mahara: Fix Committed Status in Mahara 20.10 series: Fix Committed Status in Mahara 21.04 series: Fix Committed Status in Mahara 21.10 series: Fix Committed Bug description: I think it's better for us to make 'Delete standard' and 'Delete standard element' button on SmartEvidence Editor translatable as below. File to modify: htdocs/module/framework/frameworks.php Line: 170 [ Before ] 'removestandardorelementconfirm' => 'module.framework' ); [ After ] 'removestandardorelementconfirm' => 'module.framework', 'delete' => 'module.framework' ); -------------------------- File to modify: htdocs/module/framework/lang/en.utf8/module.framework.php Line: 133 [ Before ] $string['missingrecordsdb'] = 'The following records could not be found on the DB: %s'; [ After ] $string['missingrecordsdb'] = 'The following records could not be found on the DB: %s'; $string['delete'] = 'Delete %s'; -------------------------- File to modify: htdocs/module/framework/js/editor.js Line: 56 [ Before ] JSONEditor.defaults.languages.en.remove_element_message = get_string('removestandardorelementconfirm'); // Enable select2 JSONEditor.plugins.select2.enable = true; [ After ] JSONEditor.defaults.languages.en.remove_element_message = get_string('removestandardorelementconfirm'); JSONEditor.defaults.languages.en.button_delete_row_title = get_string('delete','module.framework','{{0}}'); // Enable select2 JSONEditor.plugins.select2.enable = true; To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1942268/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
