Reviewed: https://reviews.mahara.org/c/mahara/+/13544 Committed: https://git.mahara.org/mahara/mahara/commit/9dd68e9b47b3a74ab82a8856c3d9b1dd9cbe5abd Submitter: "Robert Lyon <robe...@catalyst.net.nz>" Branch: main
commit 9dd68e9b47b3a74ab82a8856c3d9b1dd9cbe5abd Author: Doris Tam <doris...@catalyst.net.nz> Date: Tue Dec 6 15:38:03 2022 +1300 Bug 1998874: Fix up showcomments non-page comments such as peer assessment comments. Without this change clicking the link in the notification resulted in an error message and didn't show the page. Change-Id: I9653b5a0cbd64ccc8518b665413ff1870c71cd60 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1998874 Title: Fix up showcomments for non page comments causing JS error 'author_link' Status in Mahara: Fix Committed Bug description: 1. Create a page 2. Add a peer assessment block 3. Share the page to an account with peer/manager access 4. As a peer/manager, make an assessment and save 5. Go to the notification sent to the owner of the page with the showcomment url 6. Navigate to the url Expectation: on save, the page reloads with a new url parameter 'showcomment' with an id and focuses on the comment Reality: the page comments dropdown opens, and nothing is focused. Also broken page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1998874/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
