Reviewed: https://reviews.mahara.org/c/mahara/+/13800 Committed: https://git.mahara.org/mahara/mahara/commit/c52a159932df42e53a42dd36a947770a1ac92066 Submitter: "Robert Lyon <robe...@catalyst.net.nz>" Branch: 22.10_DEV
commit c52a159932df42e53a42dd36a947770a1ac92066 Author: Gold <g...@catalyst.net.nz> Date: Thu Feb 9 12:07:40 2023 +1300 Bug 2004852: LTI 1.1 grading vs some locales Ensure the format of the grade uses a dot regardless of the system locale. Signed-off-by: Gold <g...@catalyst.net.nz> Change-Id: I4b669486c2f73eff73ce940300ba26db4586e914 (cherry picked from commit 511e22608a0f72b40ae0f764e6cfc0b8d1c92d1f) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/2004852 Title: LTI 1.1 grading not working for some locales Status in Mahara: Fix Committed Status in Mahara 21.10 series: In Progress Status in Mahara 22.04 series: In Progress Status in Mahara 22.10 series: In Progress Status in Mahara 23.04 series: Fix Committed Bug description: With a LTI to a Moodle instance, when the teachers grades a submission, the grade is not sent to Moodle in some cases. I think it has to do with my server's locale set to french. The grade of 94%, for example, si translated to 0,94 instead of 0.94. I printed some debug and was able to see the error "Score must be numeric". I also printed the xml from the $body variable (see attachment). I made a few changes in function publish_lti_outcome of htdocs/module/lti/lib.php around line 1001 and it now works correctly. $grade = $this->grade / 100; $grade = str_replace(',', '.', $grade); $smarty->assign('score', $grade); This was tested with Mahara 22.10 and Moodle 3.11. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/2004852/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
