[sorry for delay with the reply, I can only blame once again my PhD for it]
On Wed, 25 Sep 2002 23:02:28 -0700 (Pacific Daylight Time) Michael A Chase
<[EMAIL PROTECTED]> wrote:
MAC> The attached patch probably shouldn't be applied since I haven't made the
MAC> GUI changes you suggested yet, but I wanted to show you what I have so far
MAC> to make sure I'm not too far off base.
No, everything seems very good for me. I didn't test the code so I could
have missed something while reading it but if it works I think it should be
applied as globally this is exactly what I'd have done myself.
MAC> > I think you only need 2 new OAC_T_* values, e.g. OAC_T_SetFlag and
MAC> > OAC_T_ClearFlag -- or maybe just one if you can combine both actions
MAC> > somehow. You're right that the encoded Settings string uses these values
MAC> > (which is why you shouldn't change their numeric values!) but ORC_T_ is for
MAC> > the new tests, so why do you need it?
MAC>
MAC> As long as I was messing with the flags, I thought being able to test them
MAC> would be handy too, so I added a flag("x") test (ORC_T_FlagSet).
I'd call it has_flag() or is_flag_set() but it's just me.
MAC> For actions, I added OAC_T_SetFlag, OAC_T_ClearFlag, and OAC_T_SetScore.
MAC> I also changed OAC_T_ChangeScore to OAC_T_AddScore to be more consistent.
No objections at all.
MAC> To help me keep things straight, I added the ORC_T_*, ORC_W_*,
MAC> ORC_L_*, and OAC_T_* names as comments to the associated arrays in
MAC> src/classes/MFilter.cpp and src/gui/wxFiltersDialog.cpp.
Thanks!
MAC> > It's not clear what clearing 'N' flag would do and also note that you
MAC> > cannot change 'R' flag at all. So "N" is really just the same as "U".
MAC>
MAC> The attached patch only changes one flag at a time from 'UDAS*'. It does
MAC> test "R" for whatever it's worth.
Very good.
MAC> I couldn't find where in the GUI code an unused array entry would be
MAC> skipped. In src/gui/wxFiltersDialog.cpp, it looks like the entire *_tTypes
MAC> arrays get passed to wxChoice(). I haven't figured out yet how m_Type or
MAC> m_Where could tell the GUI not to display certain of their elements. It
MAC> looks like a validator might do the trick, but that's probably more work
MAC> than it's worth and I'm not sure whether that would throw off the selection
MAC> indexes.
It probably would.
MAC> I added a bit in ORC_T_Flags[] and OAC_T_Flags[] so it will be easier to
MAC> identify which tests and actions aren't implemented.
It's a good start, thanks. I'll try to look at the GUI side of the things
later although, knowing me, you probably understand that it could be much
later...
MAC> I have not tried to compile the changed code, so there may be some syntax
MAC> errors. At this point, I'm more interested in having you take a look at
MAC> what I'm trying to see if it makes any sense. I'll be tackling the GUI
MAC> code tomorrow now that I think I understand what needs to be added.
Have you had any luck/time with the GUI? Don't hesitate to ask if you have
any problems.
Thanks!
VZ
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Mahogany-Developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/mahogany-developers
