Hi (Xavier),

 as you may have seen from my changes to UUDecode.cpp, there was a big
memory leak there as MimePartRaw was never deleted. I delete it now but it
doesn't help much as this is still a memory leak in all but name (it is
only freed on program termination...). Unfortunately I don't see any simple
way to really fix this, maybe you have better ideas?

 Right now, I see only 2 choices:

1. give ownership of this MimePartRaw to either MessageView or Message
   itself, i.e. ask them to delete it when it is not shown any more or
   when the Message itself is deleted.

   This would work but would make the code quite ugly. Moreover,
   ViewFilters don't even have access to MessageView (nor Message)
   currently so this would have to be changed just for this.

2. don't do this at all at ViewFilter level but create a new MessageUU
   class similar to the existing MessageVirt and which could have "virtual"
   MimePartUU parts.

 I clearly prefer the choice (2) (as I think it would have to be done for
ASCII-armoured PGP support anyhow) but it is much more work... Maybe doing
it directly at Message level, i.e. simply adding methods to create
artificial MIME parts to this class, would be slightly simpler than
creating a new MessageUU (and MessagePGP...).

 In fact, when I added ViewFilter I originally wanted to have a similar in
idea MIMEFilter class, i.e. a chain of filters which would take the
original message, examine it and possibly rearrange its MIME parts. This
would probably be the best solution.

 Regards,
VZ



-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click
_______________________________________________
Mahogany-Developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/mahogany-developers

Reply via email to