+1 On Mon, May 12, 2008 at 7:50 PM, Sean Owen (JIRA) <[EMAIL PROTECTED]> wrote:
> > [ > https://issues.apache.org/jira/browse/MAHOUT-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596254#action_12596254] > > Sean Owen commented on MAHOUT-52: > --------------------------------- > > Actually from looking more al SLF4J I like it more. The static binding > thing is nice, and so this can automatically use JCL to integrate with > Hadoop if needed (yeah, a facade of a facade :( ). > > I vote +1. I think I hear a few more votes in favor. Are we agreed? I can > change my code then convert other System.out.println and so on. > > > Standardize on java.util.logging, Commons Logging, log4j? > > --------------------------------------------------------- > > > > Key: MAHOUT-52 > > URL: https://issues.apache.org/jira/browse/MAHOUT-52 > > Project: Mahout > > Issue Type: Improvement > > Reporter: Sean Owen > > Priority: Minor > > > > I see the log4j and Commons Logging .jars in the lib/ directory. log4j > isn't used; Commons Logging is used in one class (Parametered). My code just > used java.util.logging directly. > > I figure we should standardize on one approach to logging. I personally > think they're all just about the same; the only real best practice is using > one system. > > I have always just used java.util.logging since it is built into Java > 1.4+. Commons Logging offers an extra layer of abstraction and lets you > switch between java.util.logging and log4j underneath. That's cool, but I've > not found it compelling enough to want to add another layer and another .jar > file. > > But, I guess log4j is present because hadoop uses it directly? The .jar > seems to have a dependency on it. > > In that case maybe we are better off using Commons Logging to let us > integrate with log4j logging that Hadoop uses, and leave open the > possibility of other callers using java.util.logging underneath. > > If that's cool I can switch my code to use Commons Logging. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > -- ted
