[
https://issues.apache.org/jira/browse/MAHOUT-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761854#action_12761854
]
Sean Owen commented on MAHOUT-184:
----------------------------------
True, either way these two methods must be updated together. write()
and readFields() must be updated in parallel in the subclasses or else
things break too. It feels more object-oriented to override the method
in subclasses (purists might suggest that the Node enum itself should
have a method that returns a corresponding instance of an
implementation) but it is not something I personally feel so strongly
about.
It's the same, the last arg defaults to 0.0 anyway. Assuming they
really should be the exact same double value and can't vary due to
intermediate rounding, this is right.
> Code tweaks for .df.* code
> --------------------------
>
> Key: MAHOUT-184
> URL: https://issues.apache.org/jira/browse/MAHOUT-184
> Project: Mahout
> Issue Type: Improvement
> Reporter: Sean Owen
> Assignee: Sean Owen
> Priority: Minor
> Fix For: 0.2
>
> Attachments: Tweaks_to__df__.patch
>
>
> This follows on my last email to the mailing list, and code inspection. It's
> big enough I made a patch. No surprises I hope given the consensus on code
> style and practice. Might be some good takeaways in here, or points for
> further discussion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
