[
https://issues.apache.org/jira/browse/MAHOUT-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782463#action_12782463
]
Sean Owen commented on MAHOUT-204:
----------------------------------
I've been attacking this all day. The changes are already big enough I'm
committing my current changes, but need to keep going. The major changes still
left: replacing System.out with logs, getting rid of all these type references
using the complete package name too.
There is lots of dead code and other practices that kind of concern me. If
there are changes I think deserve discussion I'll surface them.
Note, I found some code in here that carries a different copyright: Copyright
PIERSOL Engineering? See TestMatrix2D. It's commented out but I think it best
to kill it. Along with the other commented out code actually.
Also class Gamma mentions it's a port of some code from
http://www.sci.usq.edu.au/staff/leighb/graph/Top.html and a library called
Cephes 2.2. Can't find these now. Should we be concerned?
bottom line there is a lot of work to be done on this code.
> Better integration of Mahout matrix capabilities with Colt Matrix additions
> ---------------------------------------------------------------------------
>
> Key: MAHOUT-204
> URL: https://issues.apache.org/jira/browse/MAHOUT-204
> Project: Mahout
> Issue Type: Improvement
> Affects Versions: 0.3
> Reporter: Grant Ingersoll
> Fix For: 0.3
>
> Attachments: MAHOUT-204-author-cleanup.patch
>
>
> Per MAHOUT-165, we need to refactor the matrix package structures a bit to be
> more coherent and clean. For instance, there are two levels of matrix
> packages now, so those should be rectified.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
