[ 
https://issues.apache.org/jira/browse/MAHOUT-220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794976#action_12794976
 ] 

Ted Dunning commented on MAHOUT-220:
------------------------------------


Robin,

I was just looking at some of the code and was having a hard time understanding 
the way that the implementations of bayes.interfaces.DataSource were storing 
their information.  I also had trouble understand just what it was that was 
being stored.

I think that a tiny amount of package or class level comments would clear that 
up enormously.

My goal in reading the code was to understand how much my recent start on an 
sgd classifier could share with the already existing Naive bayes classifiers.  
I mention that since it alwyas helps me write comments if I know what the 
question in the reader's mind is that I need to answer. 

> Mahout Bayes Code cleanup
> -------------------------
>
>                 Key: MAHOUT-220
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-220
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Classification
>    Affects Versions: 0.3
>            Reporter: Robin Anil
>            Assignee: Robin Anil
>             Fix For: 0.3
>
>         Attachments: MAHOUT-BAYES.patch, MAHOUT-BAYES.patch
>
>
> Following isabel's checkstyle, I am adding a whole slew of code cleanup with 
> the following exceptions
> 1.  Line length used is 120 instead of 80. 
> 2.  static final log is kept as is. not LOG. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to