Personally I'm a fan of judicious use of static imports if readability is good (esp. If there's only one class you're statically importing from), because who writes java code without an ide?
Just my two cents. On Feb 20, 2010 9:08 AM, "Drew Farris (JIRA)" <j...@apache.org> wrote: [ https://issues.apache.org/jira/browse/MAHOUT-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836207#action_12836207] Drew Farris commented on MAHOUT-299: ------------------------------------ Thanks for the review Sean, I'll get it committed sometime today if I can steal some time to do so (sometime this weekend, worst case). Point taken about the static imports, I prefer the readability, but I probably rely on my IDE too much to track down references like that, so I'll remove them to conform with the overall style we're following. Same about RuntimeException, will revsie that as well. Once those changes are complete, I'll commit and close the issue -- all in all it will be a great way to test my Karma. > Collocations: improve performance by making Gram BinaryComparable > ----------------------------...
