[ 
https://issues.apache.org/jira/browse/MAHOUT-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854432#action_12854432
 ] 

Sean Owen commented on MAHOUT-358:
----------------------------------

The output is helpful. I am more confused, we may be talking about different 
things. userID could well be negative. It's a long. What is your input like? 
how are you mapping user IDs to longs? That is not a problem per se, but I 
would like to understand what your user IDs are like.

Earlier your output showed negative *values*, not *IDs*, and that is something 
I can't figure out. But we don't see that here.

Actually, this output seems correct to me.


Which are you talking about Sebastian?

I can't quite understand why you would see more than 10 recommendations since 
as you see, the queue is kept to this size in the code above. I can try one or 
two more changes that try to make the code even more straightforward (e.g. 
moving the ordering logic in a Comparator, not reusing Writables in case 
something strange goes on there.)

Is the change to Text really a solution -- I am not yet clear we're talking 
about the same issue. I can't see how this changes behavior. We're already 
seeing that RecommendedItemsWrtiable.toString() is being invoked. I do not see 
how String.valueOf(long) could return the 'right' value, but 
StringBuffer.append(long) the 'wrong' value. They're calling into the same 
java.lang code in the end.

Very very confused here, esp since I cannot reproduce this.

Could it be a Hadoop version issue? I'm on 0.20.2.

I will commit any wild-guess changes I can here in a minute in an effort to 
shed any light.

> the pref value  field of output of 
> org.apache.mahout.cf.taste.hadoop.item.RecommenderJob has negative
> -----------------------------------------------------------------------------------------------------
>
>                 Key: MAHOUT-358
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-358
>             Project: Mahout
>          Issue Type: Test
>          Components: Collaborative Filtering
>    Affects Versions: 0.4
>            Reporter: Hui Wen Han
>         Attachments: 20100407_steer_item_out_part-00000, 
> attempt_201004011623_0070_m_000000_0.htm, screenshot-1.jpg, screenshot-2.jpg
>
>
> In my test the input pref values all is positive.
> the output score value has negative value ,

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to