[ 
https://issues.apache.org/jira/browse/MAHOUT-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854568#action_12854568
 ] 

Hui Wen Han edited comment on MAHOUT-358 at 4/7/10 4:15 PM:
------------------------------------------------------------

it's very good now,thanks Sean! :)

only one little issue ,can ignore line that has no recommendations ?

-2146704409350804772    
[-5143306609724270245:0.0,-6887672525304767274:0.0,-7869337437647864448:0.0,1143520528292887196:0.0,4565256005884091248:0.0,-403573745216718449:0.0]
-2140684086652787668    
[5066321748533664330:3.33,-6196380629601347193:2.22,1388936500341917293:2.22,-5143306609724270245:2.22,-6887672525304767274:2.22,-403573745216718449:2.22,4000074642144994975:0.0,1471545749001003492:0.0,8619821060300841906:0.0,-8796495370659715938:0.0]
-2087578807957211564    [3693944382462874249:0.0]
-2084997234534227590    []
-1994184181161252808    []
-1956807977260853620    []
-1905139778468734800    []
-1897443610249479948    []
-1861747039795463904    []
-1783644832320395644    []
-1759587438285537664    []
-1598157027497721376    []
-1524111942416072322    []
-1508995658783890206    []
-1478238285808155750    []
-1473372051895027798    []
-1360993164612489840    []
-1170376071408489552    [-8608197272004918866:0.0,-8235449048613678861:0.0]
-1106281807063652538    []

It seems that 
vector.iterateNonZero() can not skip the zero value.

also in UserVectorToCooccurrenceReducer, the following code seems does not 
need. 
because some user has little preferences,if we purge here ,maybe he can not get 
recommendation. 

      Iterator<Vector.Element> cooccurrences = cooccurrenceRow.iterateNonZero();
      while (cooccurrences.hasNext()) {
        Vector.Element element = cooccurrences.next();
        if (element.get() <= 1.0) { // purge small values
          element.set(0.0);
        }
      }



      was (Author: huiwenhan):
    it's very good now,thanks Sean! :)

only one little issue ,can ignore line that has no recommendations ?

-2146704409350804772    
[-5143306609724270245:0.0,-6887672525304767274:0.0,-7869337437647864448:0.0,1143520528292887196:0.0,4565256005884091248:0.0,-403573745216718449:0.0]
-2140684086652787668    
[5066321748533664330:3.33,-6196380629601347193:2.22,1388936500341917293:2.22,-5143306609724270245:2.22,-6887672525304767274:2.22,-403573745216718449:2.22,4000074642144994975:0.0,1471545749001003492:0.0,8619821060300841906:0.0,-8796495370659715938:0.0]
-2087578807957211564    [3693944382462874249:0.0]
-2084997234534227590    []
-1994184181161252808    []
-1956807977260853620    []
-1905139778468734800    []
-1897443610249479948    []
-1861747039795463904    []
-1783644832320395644    []
-1759587438285537664    []
-1598157027497721376    []
-1524111942416072322    []
-1508995658783890206    []
-1478238285808155750    []
-1473372051895027798    []
-1360993164612489840    []
-1170376071408489552    [-8608197272004918866:0.0,-8235449048613678861:0.0]
-1106281807063652538    []
  
> the pref value  field of output of 
> org.apache.mahout.cf.taste.hadoop.item.RecommenderJob has negative
> -----------------------------------------------------------------------------------------------------
>
>                 Key: MAHOUT-358
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-358
>             Project: Mahout
>          Issue Type: Test
>          Components: Collaborative Filtering
>    Affects Versions: 0.4
>            Reporter: Hui Wen Han
>         Attachments: 20100407_steer_item_out_part-00000, 
> 2010_input_steer_item_in_prefs-1.dat, 
> attempt_201004011623_0070_m_000000_0.htm, screenshot-1.jpg, screenshot-2.jpg, 
> screenshot-3.jpg
>
>
> In my test the input pref values all is positive.
> the output score value has negative value ,

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to