Mark Sapiro pushed to branch master at GNU Mailman / Mailman Core
Commits:
abd25a8f by Mark Sapiro at 2020-08-15T17:15:21-07:00
Include owners in filter_action forwarded messages.
- - - - -
9a661aca by Mark Sapiro at 2020-08-16T00:39:03+00:00
Merge branch 'fa_fwd' into 'master'
Include owners in filter_action forwarded messages.
Closes #753
See merge request mailman/mailman!687
- - - - -
3 changed files:
- src/mailman/docs/NEWS.rst
- src/mailman/handlers/mime_delete.py
- src/mailman/handlers/tests/test_mimedel.py
Changes:
=====================================
src/mailman/docs/NEWS.rst
=====================================
@@ -30,6 +30,9 @@ Bugs
* A member subscribed as a User can now be unsubscribed. (Closes #734)
* When a handler rejects or discards a message, it won't be delivered or
archived anyway. (Closes #752)
+* Messages forwarded when content filtering removes the entire message and
+ ``filter_action`` is forward now go to owners as well as moderators.
+ (Closes #753)
Command line
------------
=====================================
src/mailman/handlers/mime_delete.py
=====================================
@@ -66,7 +66,7 @@ message.
""")
subject = _('Content filter message notification')
- notice = OwnerNotification(mlist, subject, roster=mlist.moderators)
+ notice = OwnerNotification(mlist, subject, roster=mlist.administrators)
notice.set_type('multipart/mixed')
notice.attach(MIMEText(text))
notice.attach(MIMEMessage(msg))
=====================================
src/mailman/handlers/tests/test_mimedel.py
=====================================
@@ -123,12 +123,12 @@ Message-ID: <ant>
get_queue_messages('bad', expected_count=0)
def test_dispose_forward(self):
- # The disposed message gets forwarded to the list moderators. So
- # first add some moderators.
+ # The disposed message gets forwarded to the list administrators. So
+ # first add an owner and a moderator.
user_manager = getUtility(IUserManager)
anne = user_manager.create_address('a...@example.com')
bart = user_manager.create_address('b...@example.com')
- self._mlist.subscribe(anne, MemberRole.moderator)
+ self._mlist.subscribe(anne, MemberRole.owner)
self._mlist.subscribe(bart, MemberRole.moderator)
# Now set the filter action and dispose the message.
self._mlist.filter_action = FilterAction.forward
View it on GitLab:
https://gitlab.com/mailman/mailman/-/compare/6c03227657abe8c896a3db75ceacfd7a7f7b64ff...9a661aca58487828a0448dd23f6e0d972c82e2fc
--
View it on GitLab:
https://gitlab.com/mailman/mailman/-/compare/6c03227657abe8c896a3db75ceacfd7a7f7b64ff...9a661aca58487828a0448dd23f6e0d972c82e2fc
You're receiving this email because of your account on gitlab.com.
_______________________________________________
Mailman-checkins mailing list -- mailman-checkins@python.org
To unsubscribe send an email to mailman-checkins-le...@python.org
https://mail.python.org/mailman3/lists/mailman-checkins.python.org/
Member address: arch...@jab.org
