Mark Sapiro pushed to branch master at GNU Mailman / Mailman Core
Commits: 28b7b98b by Mark Sapiro at 2020-11-14T13:39:40-08:00 Increased the size of the data column in the workflowstate table. - - - - - 551390c4 by Mark Sapiro at 2020-11-14T22:02:19+00:00 Merge branch 'workflow' into 'master' Increased the size of the data column in the workflowstate table. Closes #793 See merge request mailman/mailman!730 - - - - - 3 changed files: - + src/mailman/database/alembic/versions/2b73fbcc97c9_increase_workflowstate_data_column_size.py - src/mailman/docs/NEWS.rst - src/mailman/model/workflow.py Changes: ===================================== src/mailman/database/alembic/versions/2b73fbcc97c9_increase_workflowstate_data_column_size.py ===================================== @@ -0,0 +1,44 @@ +# Copyright (C) 2020 by the Free Software Foundation, Inc. +# +# This file is part of GNU Mailman. +# +# GNU Mailman is free software: you can redistribute it and/or modify it under +# the terms of the GNU General Public License as published by the Free +# Software Foundation, either version 3 of the License, or (at your option) +# any later version. +# +# GNU Mailman is distributed in the hope that it will be useful, but WITHOUT +# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or +# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for +# more details. +# +# You should have received a copy of the GNU General Public License along with +# GNU Mailman. If not, see <https://www.gnu.org/licenses/>. + +"""increase_workflowstate_data_column_size + +Revision ID: 2b73fbcc97c9 +Revises: 9735f5e5dbdb +Create Date: 2020-11-14 12:25:50.833363 + +""" + +from alembic import op +from mailman.database.types import SAUnicode, SAUnicodeLarge + + +# revision identifiers, used by Alembic. +revision = '2b73fbcc97c9' +down_revision = '9735f5e5dbdb' + + +def upgrade(): + # Adding the invitation parameter can make the data value too long for + # MySQL SaUnicode. + with op.batch_alter_table('workflowstate') as batch_op: + batch_op.alter_column('data', type_=SAUnicodeLarge) + + +def downgrade(): + with op.batch_alter_table('workflowstate') as batch_op: + batch_op.alter_column('data', type_=SAUnicode) ===================================== src/mailman/docs/NEWS.rst ===================================== @@ -16,6 +16,8 @@ Here is a history of user visible changes to Mailman. Bugs ---- * Handle some UnicodeEncodeErrors in creating digests. (Closes #560) +* Increased the size of the data column in the workflowstate table. + (Closes #793) 3.3.2 ===== ===================================== src/mailman/model/workflow.py ===================================== @@ -19,7 +19,7 @@ from mailman.database.model import Model from mailman.database.transaction import dbconnection -from mailman.database.types import SAUnicode +from mailman.database.types import SAUnicode, SAUnicodeLarge from mailman.interfaces.workflow import IWorkflowState, IWorkflowStateManager from public import public from sqlalchemy import Column @@ -35,7 +35,7 @@ class WorkflowState(Model): token = Column(SAUnicode, primary_key=True) step = Column(SAUnicode) - data = Column(SAUnicode) + data = Column(SAUnicodeLarge) @public View it on GitLab: https://gitlab.com/mailman/mailman/-/compare/9bc78976f5b4d1185cd667552133893f23dd36ce...551390c4eadb657e54b58c4e3d05b60dee2a3dbe -- View it on GitLab: https://gitlab.com/mailman/mailman/-/compare/9bc78976f5b4d1185cd667552133893f23dd36ce...551390c4eadb657e54b58c4e3d05b60dee2a3dbe You're receiving this email because of your account on gitlab.com.
_______________________________________________ Mailman-checkins mailing list -- mailman-checkins@python.org To unsubscribe send an email to mailman-checkins-le...@python.org https://mail.python.org/mailman3/lists/mailman-checkins.python.org/ Member address: arch...@jab.org
