Mark Sapiro pushed to branch master at GNU Mailman / Mailman Core
Commits:
7ef7bc78 by Mark Sapiro at 2021-04-09T15:15:22-07:00
Fix race condition on concurrent deletions.
- - - - -
b5c4cf1a by Mark Sapiro at 2021-04-09T22:47:22+00:00
Merge branch 'fix' into 'master'
Fix race condition on concurrent deletions.
See merge request mailman/mailman!821
- - - - -
1 changed file:
- src/mailman/app/moderator.py
Changes:
=====================================
src/mailman/app/moderator.py
=====================================
@@ -176,7 +176,8 @@ def handle_message(mlist, id, action, comment=None,
forward=None):
user_token = None
pendings = getUtility(IPendings)
for token, data in pendings.find(pend_type='held message'):
- if data['id'] == id:
+ # This can return None if there is a concurrent deletion.
+ if data and data['id'] == id:
user_token = token
break
if user_token is not None:
View it on GitLab:
https://gitlab.com/mailman/mailman/-/compare/58f39d373e49743d41f06cd9a2aebe4bebb62b72...b5c4cf1a2ee09458481a724b66bb8dd638643bb3
--
View it on GitLab:
https://gitlab.com/mailman/mailman/-/compare/58f39d373e49743d41f06cd9a2aebe4bebb62b72...b5c4cf1a2ee09458481a724b66bb8dd638643bb3
You're receiving this email because of your account on gitlab.com.
_______________________________________________
Mailman-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/mailman-checkins.python.org/
Member address: [email protected]
