Mark Sapiro pushed to branch master at GNU Mailman / Mailman Core


Commits:
58b38d86 by Mark Sapiro at 2022-10-22T20:07:58+00:00
Avoid an AttributeError in task runner.

Fixes #1028

- - - - -
638f08ec by Mark Sapiro at 2022-10-22T20:07:58+00:00
Merge branch 'task' into 'master'

Avoid an AttributeError in task runner.

Closes #1028

See merge request mailman/mailman!1044
- - - - -


2 changed files:

- src/mailman/docs/NEWS.rst
- src/mailman/runners/task.py


Changes:

=====================================
src/mailman/docs/NEWS.rst
=====================================
@@ -79,6 +79,8 @@ Bugs fixed
 * The ``mailman import21`` command now adds ``^listname@`` to the list's
   ``acceptable_aliases`` for compatiblity with Mailman 2.1's behavior.
   (Closes #1032)
+* An ``AttributeError`` thrown in the task runner, possibly due to a race
+  condition, is now avoided.  (Closes #1028)
 
 REST
 ----


=====================================
src/mailman/runners/task.py
=====================================
@@ -94,6 +94,8 @@ class TaskRunner(Runner):
         # Also, delete any orphaned messages from the message store.
         mids = dict()
         for token, pendable in pendings:
+            if not pendable:
+                continue                                # pragma: nocover
             mid = pendable.get('_mod_message_id')
             if mid:
                 mids[mid] = True



View it on GitLab: 
https://gitlab.com/mailman/mailman/-/compare/dc48d36bc94eedb8e7c7453fd7969cd81780a0c3...638f08eca1a539aa75672d1c33c6e6b506302c60

-- 
View it on GitLab: 
https://gitlab.com/mailman/mailman/-/compare/dc48d36bc94eedb8e7c7453fd7969cd81780a0c3...638f08eca1a539aa75672d1c33c6e6b506302c60
You're receiving this email because of your account on gitlab.com.


_______________________________________________
Mailman-checkins mailing list -- mailman-checkins@python.org
To unsubscribe send an email to mailman-checkins-le...@python.org
https://mail.python.org/mailman3/lists/mailman-checkins.python.org/
Member address: arch...@jab.org

Reply via email to