Mark Sapiro pushed to branch master at GNU Mailman / Mailman Core


Commits:
de20d1d4 by Mark Sapiro at 2023-09-22T14:56:23-07:00
Don't delete DSN from message store.  It might be needed for another notice.

- - - - -
449d9173 by Mark Sapiro at 2023-09-22T22:27:53+00:00
Merge branch 'dsn' into 'master'

Don't delete DSN from message store.  It might be needed for another notice.

Closes #1101

See merge request mailman/mailman!1145

Merged-by: Mark Sapiro <m...@msapiro.net>

Reviewed-by: 
- - - - -


2 changed files:

- src/mailman/app/notifications.py
- src/mailman/docs/NEWS.rst


Changes:

=====================================
src/mailman/app/notifications.py
=====================================
@@ -38,12 +38,10 @@ log = logging.getLogger('mailman.error')
 
 
 def _get_dsn(message_id):
-    # Get the DSN from the message store and delete it from the message store.
+    # Get the DSN from the message store. Don't delete it as it may still be
+    # needed.
     messagestore = getUtility(IMessageStore)
-    dsn = messagestore.get_message_by_id(message_id)
-    if dsn:
-        messagestore.delete_message(message_id)
-    return dsn
+    return messagestore.get_message_by_id(message_id)
 
 
 def _make_multipart(msg):


=====================================
src/mailman/docs/NEWS.rst
=====================================
@@ -58,6 +58,8 @@ Bugs fixed
   message rather than the content filtered one.  (Closes #1089)
 * List welcome and goodbye messages to users with English preferred_language
   now have their Subject: RFC 2047 encoded as needed.  (Closes #1098)
+* Bounce processing notifications due to a DSN for multiple users now have the
+  DSN attached to each notice.  (Closes #1101)
 
 New Features
 ------------



View it on GitLab: 
https://gitlab.com/mailman/mailman/-/compare/18ff5ed75e5195166d52ec51209bbbd7b3522116...449d917342563c1c6dccc049c75b8b06dae876d3

-- 
View it on GitLab: 
https://gitlab.com/mailman/mailman/-/compare/18ff5ed75e5195166d52ec51209bbbd7b3522116...449d917342563c1c6dccc049c75b8b06dae876d3
You're receiving this email because of your account on gitlab.com.


_______________________________________________
Mailman-checkins mailing list -- mailman-checkins@python.org
To unsubscribe send an email to mailman-checkins-le...@python.org
https://mail.python.org/mailman3/lists/mailman-checkins.python.org/
Member address: arch...@jab.org

Reply via email to