Bugs item #609692, was opened at 2002-09-15 22:07
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=100103&aid=609692&group_id=103
Category: mail delivery
Group: 2.1 beta
Status: Open
Resolution: None
Priority: 5
Submitted By: Les Niles (lniles)
Assigned to: Nobody/Anonymous (nobody)
Summary: Non-member hold reason is wrong
Initial Comment:
Maybe I'm missing something, but it would seem
that Handlers.Moderate.process() should call
hold.hold_for_approval() with a fourth arg of
Hold.NonMemberPost instead of Hold.ModeratedPost
at line 85. The latter causes confusion for the typical
case of a member (person) posting from other than
her subscribed email address, since she gets back a
message saying that the post was to a moderated
list. And the default reject message for the
moderator, something about the posting being
deemed inappropriate, is not appropriate. :)
----------------------------------------------------------------------
Comment By: Tokio Kikuchi (tkikuchi)
Date: 2002-10-16 06:30
Message:
Logged In: YES
user_id=67709
I am sending a patch to raise attention: sorry for the
inconvenience with the folded lines but only two lines. (TK)
--- /home/mailman/src/mailman/Mailman/Handlers/Moderate.py
Wed Jul 10 04:29
:53 2002
+++ Moderate.py Wed Oct 16 15:25:26 2002
@@ -82,7 +82,7 @@
if matches_p(sender, mlist.accept_these_nonmembers):
return
if matches_p(sender, mlist.hold_these_nonmembers):
- Hold.hold_for_approval(mlist, msg, msgdata,
Hold.ModeratedPost)
+ Hold.hold_for_approval(mlist, msg, msgdata,
Hold.NonMemberPost)
# No return
if matches_p(sender, mlist.reject_these_nonmembers):
do_reject(mlist)
@@ -98,7 +98,7 @@
# Accept
return
elif mlist.generic_nonmember_action == 1:
- Hold.hold_for_approval(mlist, msg, msgdata,
Hold.ModeratedPost)
+ Hold.hold_for_approval(mlist, msg, msgdata,
Hold.NonMemberPost)
elif mlist.generic_nonmember_action == 2:
do_reject(mlist)
elif mlist.generic_nonmember_action == 3:
----------------------------------------------------------------------
Comment By: Les Niles (lniles)
Date: 2002-09-18 16:56
Message:
Logged In: YES
user_id=92931
Oops -- Hold.NonMemberPost should replace
Hold.ModeratedPost at line 101, not line 85. (This is
in Sept 3 2002 CVS.)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=100103&aid=609692&group_id=103
_______________________________________________
Mailman-Developers mailing list
[EMAIL PROTECTED]
http://mail.python.org/mailman-21/listinfo/mailman-developers
