>>>>> "David" == David Engster <[email protected]> writes:

David> A while ago I posted some patches for dealing with changing
David> flags of maildir messages:

David> http://article.gmane.org/gmane.mail.mairix.user/72

David> I now integrated those in a git repository, which you can clone
David> from with this URL

David> http://www.randomsample.de/mairix.git

I like those patches and am looking forward to trying the Gnus
interface, but I have a stylistic concern about them: your patches do
not follow mairix code source style -- for example, you have

    if( (ret == GLOB_NOMATCH) && change_new_to_cur(target_glob) )

while mairix code would be more like

    if ((ret == GLOB_NOMATCH) && change_new_to_cur(target_glob))

(space after operators like "if", no space within parentheses), and
also your changes contain lots of trailing whitespaces.

This may look like I am nitpicking, but having an homogeneous style
throughout the program is very helpful for readers and maintainers.

  Sam
-- 
Samuel Tardieu -- [email protected] -- http://www.rfc1149.net/


------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
_______________________________________________
Mairix-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mairix-users

Reply via email to