Consider the attached setup, where the Makefile.PL in sub dir fails to 
eval at run time because of function redefinition error under:

   use warnings FATAL => 'all'

There are two problems in MakeMaker here:

1. The failure of evaluation of subdir/Makefile.PL is reported as WARNING

2. It doesn't abort the execution of the top level Makefile.PL, which 
IMHO is wrong, since in big projects like mod_perl 2.0 there are many 
many sub-dirs and the output is quite long to easily notice this kind of 
WARNING messages.

I don't know why somebody will want to proceed if at least one Makefile 
wasn't created.

suggestions:

s/WARNING/ERROR/
and
die if $@

I've tried to make some compile errors and the printed $@ was bigger and 
easier to notice, but no so with runtime errors.

Thanks!

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Attachment: patch
Description: application/java-vm

Reply via email to