Great work.

Orton, Yves wrote:
> But more importantly filename_is_absolute (here edited as I describe above)
> uses somewhat interesting logic:
> 
> sub file_name_is_absolute {
>     my ($self,$file) = @_;
>     return scalar(($file||"") =~ m{^([a-z]:)?[\\/]}is);
> }
> 
> So this says the filename is absolute if it begin with a volume _and_ starts
> with a slash, or just starts with a slash.
> 
> I kinda wonder if a better logic would be to say its absolute if it begins
> with a volume or if it begins with a slash.

(According to util.h, the perl internals consider a filename to be
absolute under Win32 if it matches /^\//, /^\\/ or /^.:/.)

I'd prefer a patch to MakeMaker than to
File::Spec::Win32::file_name_is_absolute(), because it's more
backward-compatible, less intrusive. Any comments from the experts
before I apply it ?

Reply via email to