Michael G Schwern wrote: > On Wed, Nov 05, 2003 at 12:56:35AM +0100, Rafael Garcia-Suarez wrote: > > > Undertested commits leads to major breakage. > > > SDBM_File won't build anymore... > > ext/SDBM_File/sdbm/Makefile.PL overrides top_targets but doesn't call the > superclass. That's really fishy and fragile. In particular, it means > the blibdirs target never gets written. > > Frankly, the whole sdbm directory is fishy. But that's old news.
Yes indeed. But how many fishy Makefile.PLs are there out there ? Usually *you*'re a member of the Backward Compatibility Police... > The correct way to fix this is to make its top_targets() override sensible > and call its parent to make sure everything gets written. > > --- ext/SDBM_File/sdbm/Makefile.PL 2003-11-04 15:50:29.000000000 -0800 > +++ ext/SDBM_File/sdbm/Makefile.PL 2003-11-04 17:53:49.000000000 -0800
