John Peacock wrote:
> It was pointed out to me that ExtUtils::MakeMaker is needlessly warning when
> someone uses a line like this:
>
> use version; our $VERSION = qv('2.0.0');
>
> The warning can be safely ignored, but it would be better if EU::MM were to be
> less whiny about this. A trivial patch follows:
>
> --- MakeMaker.pm.orig 2006-12-25 13:10:21.000000000 -0500
> +++ MakeMaker.pm 2006-12-25 13:13:59.000000000 -0500
> @@ -90,6 +90,7 @@
> SKIP => 'array',
> TYPEMAPS => 'array',
> XS => 'hash',
> + VERSION => ['version',''],
> _KEEP_AFTER_FLUSH => '',
>
> clean => 'hash',
If I'm not mistaken that's the Makefile.PL argument handling code which should
not be related to the $VERSION checking code. Furthermore, I see no warning.
0 windhund ~/tmp/Foo$ cat Makefile.PL
#!/usr/bin/perl -w
use ExtUtils::MakeMaker;
WriteMakefile(
NAME => "Foo",
VERSION_FROM => "lib/Foo.pm"
);
0 windhund ~/tmp/Foo$ cat lib/Foo.pm
package Foo;
use version; our $VERSION = qv('2.0.0');
0 windhund ~/tmp/Foo$ perl Makefile.PL
Writing Makefile for Foo
0 windhund ~/tmp/Foo$ mod_version_check ExtUtils::MakeMaker
6.31
So what's the warning you're seeing?
