On Dec 7, 2007 10:41 AM, Michael G Schwern <[EMAIL PROTECTED]> wrote:
> Thanks, Craig. I decided to fix a few things as long as we were at it. I
> changed the name to be more accurate and also fixed it so it won't give up
> when it sees a macro declaration.
>
> Could you try out the attached patch?
Almost there. I applied this to blead and it successfully built all
the core extensions and passed all the existing tests. I looked at
the YAML-generating code in some of the generated makefiles and it
looks good.
The new test fails on VMS because the "default filter" case is MM_VMS,
not MM_Unix. You need something like this and it will pass:
--- t/maketext_filter.t;-0 Fri Dec 7 11:24:58 2007
+++ t/maketext_filter.t Fri Dec 7 17:33:39 2007
@@ -20,7 +20,7 @@ sub test_filter {
my($text, $vms_text) = @_;
local $Test::Builder::Level = $Test::Builder::Level + 1;
- is( MM->maketext_filter($text), $text, 'default
filter' );
+ is( ExtUtils::MM_Unix->maketext_filter($text),
$text, 'default filter' );
is( ExtUtils::MM_VMS->maketext_filter($text), $vms_text, 'VMS filter' );
}
