Author: bobby Date: Mon Apr 1 17:48:59 2013 New Revision: 1463224 URL: http://svn.apache.org/r1463224 Log: svn merge -c 1463221 FIXES: MAPREDUCE-4974. Optimising the LineRecordReader initialize() method (Gelesh via bobby)
Modified: hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/LineRecordReader.java Modified: hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt?rev=1463224&r1=1463223&r2=1463224&view=diff ============================================================================== --- hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt (original) +++ hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt Mon Apr 1 17:48:59 2013 @@ -45,6 +45,9 @@ Release 0.23.7 - UNRELEASED MAPREDUCE-4822. Unnecessary conversions in History Events. (Chu Tong via jlowe) + MAPREDUCE-4974. Optimising the LineRecordReader initialize() method + (Gelesh via bobby) + BUG FIXES MAPREDUCE-4278. cannot run two local jobs in parallel from the same Modified: hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/LineRecordReader.java URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/LineRecordReader.java?rev=1463224&r1=1463223&r2=1463224&view=diff ============================================================================== --- hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/LineRecordReader.java (original) +++ hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/LineRecordReader.java Mon Apr 1 17:48:59 2013 @@ -81,13 +81,13 @@ public class LineRecordReader extends Re start = split.getStart(); end = start + split.getLength(); final Path file = split.getPath(); - compressionCodecs = new CompressionCodecFactory(job); - codec = compressionCodecs.getCodec(file); // open the file and seek to the start of the split final FileSystem fs = file.getFileSystem(job); fileIn = fs.open(file); if (isCompressedInput()) { + compressionCodecs = new CompressionCodecFactory(job); + codec = compressionCodecs.getCodec(file); decompressor = CodecPool.getDecompressor(codec); if (codec instanceof SplittableCompressionCodec) { final SplitCompressionInputStream cIn = @@ -166,9 +166,6 @@ public class LineRecordReader extends Re while (getFilePosition() <= end) { newSize = in.readLine(value, maxLineLength, Math.max(maxBytesToConsume(pos), maxLineLength)); - if (newSize == 0) { - break; - } pos += newSize; if (newSize < maxLineLength) { break; @@ -219,4 +216,4 @@ public class LineRecordReader extends Re } } } -} +} \ No newline at end of file