Jose Luis López created MAPREDUCE-7542:
------------------------------------------

             Summary: Shut down leaked mini-cluster instances
                 Key: MAPREDUCE-7542
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7542
             Project: Hadoop Map/Reduce
          Issue Type: Test
          Components: test
            Reporter: Jose Luis López


Part of the mini-cluster leak scan recorded in HDFS-17957, I came across with 
two leaks in the MAPREDUCE project:
 
* TestNNBench#testNNBenchCrossCluster shuts its dfsCluster down only on the
happy path, so the cluster leaks exactly when the test fails.
* TestDelegationToken holds a cluster in a field with no teardown in the class
or its ancestors.
 
Impact: a leaked cluster keeps threads, heap and ports alive under the
remaining tests of the class, and a failure on the happy-path-only pattern can
cascade into bogus failures of later tests in the same class.
 
The fixes are mechanical - shutdown in a finally block, and a teardown method.
 
Test-scope only; no production code is touched.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to