[
https://issues.apache.org/jira/browse/MAPREDUCE-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728583#action_12728583
]
Vinod K V commented on MAPREDUCE-40:
------------------------------------
Looked at the latest patch. Have some more comments:
TaskTracker.java
- in initializeMemoryManagement, need to also handle
UPPER_LIMIT_ON_TASK_VMEM_PROPERTY
CapacitySchedulerConf.java
- This class is not public. So need for back support config values in here.
Revert all the changes in this file.
- The corresponding variables need to handled by printing out warning messages
wherever they are used.
TestCapacityScheduler.java
- Removed spurious empty line before testDeprecatedValues
CapacityTaskScheduler.java
- initializeMemoryRelatedConf
-- need to handle UPPER_LIMIT_ON_TASK_VMEM_PROPERTY, limitMaxPmemForTasks,
MAPRED_TASK_DEFAULT_MAXVMEM_PROPERTY, defaultPercentOfPmemInVmem
-- we are checking for presence of new map value only. It should be either
map or reduce value, I think. In other words, if any of the two new config
params is used, old param will be disgarded. Also modify
TestCapacityScheduler.testDeprecatedValues testing this.
JobConf.java
- setMaxVirtualMemoryForTask - documentation is wrongly aligned.
- getMaxVirtualMemoryForTask():
-- we are checking for presence of new map value only. It should be either
map or reduce value, I think. Also modify TestJobConf testing this.
-- No deprecated variable log messages? (previous review comment missed)
TestJobConf.java
- Remove useless empty lines
- Missing tests
-- getMemoryForMapTask() and getMemoryForReduceTask() : old=value A, new=Not
present, result=Old value
-- tests for getMaxVirtualMemoryForTask() and setMaxVirtualMemoryForTask()
(previous review comment missed)
> Memory management variables need a backwards compatibility option after
> HADOOP-5881
> -----------------------------------------------------------------------------------
>
> Key: MAPREDUCE-40
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-40
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Hemanth Yamijala
> Assignee: rahul k singh
> Priority: Blocker
> Attachments: hadoop-5919-1.patch, hadoop-5919-2.patch,
> hadoop-5919-3.patch, hadoop-5919-4.patch, hadoop-5919-5.patch,
> hadoop-5919-6.patch, hadoop-5919-7.patch
>
>
> HADOOP-5881 modified variables related to memory management without looking
> at the backwards compatibility angle. This JIRA is to adress the gap. Marking
> it a blocker for 0.20.1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
