[ 
https://issues.apache.org/jira/browse/MAPREDUCE-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo (Nicholas), SZE updated MAPREDUCE-770:
---------------------------------------------

    Component/s: test
       Priority: Minor  (was: Major)

> That's what they DO.  Shouldn't this stuff be protected with a try ... 
> finally construct?
Yes, this is a good improvement over the tests.

Change the priority to minor since this helps when the unit test fails with an 
AssertionFailedError but the unit test is not supposed to fail.  In the case 
that the unit test fails, we could do "ant clean".

> org.apache.hadoop.tools.TestCopyFiles may leave junk files when an assertion 
> fails
> ----------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-770
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-770
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>            Reporter: Dick King
>            Priority: Minor
>
> In most of the testXxxYyyZzz methods, the code runs:
>    preliminaries
>    ToolRunner( ..., new String[] { local and DFS filenames and more filenames 
> });
>    assertMaybe("this result stank", conditions);
>    assertMaybe("this other result stank", conditions);
>    deldir(deletee's name);
>    deldir(second deletee's name);
> The assertMaybe's throw AssertionFailedError .  That's what they DO.  
> Shouldn't this stuff be protected with a try ... finally construct?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to