[ 
https://issues.apache.org/jira/browse/MAPREDUCE-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741191#action_12741191
 ] 

Sreekanth Ramakrishnan commented on MAPREDUCE-824:
--------------------------------------------------

Started taking look at the patch, following are comments:

QueueSchedulingContext:
* Can a comment be added for the each of the fields of the 
QueueSchedulingContext, stating what each is meant to do?
AbstractQueue
* Change cummulative to cumulative.
* Childrens should be children
* Can we move the queue scheduling information string into 
QueueSchedulingContext? As we have for the TaskSchedulingContext?
* Can we take away state variables prevReduceClusterCapacity and 
prevMapClusterCapacity so there is no state maintained?

JobQueue:-
* Why are we having the jobStateChanged method in JobQueue, shouldnt it be in 
JobQueueManager which is JobInProgressListener and shouldn't it be handling the 
job state change event and handling and management of movement of jobs?

JobInitalizationPoller:
*Do we need to change the log statements? (Queue to AbstractQueue? Or Should it 
be JobQueue?)
* What would QueueManager.getQueues() give to {{JobInitializationPoller}} in 
{{CapacityScheduler.start()}}

> Support a hierarchy of queues in the capacity scheduler
> -------------------------------------------------------
>
>                 Key: MAPREDUCE-824
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-824
>             Project: Hadoop Map/Reduce
>          Issue Type: New Feature
>          Components: contrib/capacity-sched
>            Reporter: Hemanth Yamijala
>         Attachments: HADOOP-824-1.patch
>
>
> Currently in Capacity Scheduler, cluster capacity is divided among the queues 
> based on the queue capacity. These queues typically represent an organization 
> and the capacity of the queue represents the capacity the organization is 
> entitled to. Most organizations are large and need to divide their capacity 
> among sub-organizations they have. Or they may want to divide the capacity 
> based on a category or type of jobs they run. This JIRA covers the 
> requirements and other details to provide the above feature.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to