[ 
https://issues.apache.org/jira/browse/MAPREDUCE-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748216#action_12748216
 ] 

Hong Tang commented on MAPREDUCE-751:
-------------------------------------

The patch looks mostly good. +1 except for the following:
- warning found during patch:
{noformat}
patching file ivy.xml
Hunk #1 succeeded at 273 (offset -4 lines).
patching file ivy/libraries.properties
Hunk #1 succeeded at 49 (offset -1 lines).
Hunk #2 succeeded at 69 (offset -1 lines).
{noformat}

- extra unused dependency on org.json in ivy.xml is introduced

- class TreePath needs to be public (including its constructors) because it is 
referenced by DeepCompare and DeepCompareException.

- constructor   public LoggedNetworkTopology(HashSet<ParsedHost> hosts, String 
name, int level) {
        refers a package private class ParsedHost. suggest to change this 
constructors to be package private.

- boolean finalParameter = false;
        unused variables in ParsedConfigFile.java

> Rumen: a tool to extract job characterization data from job tracker logs
> ------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-751
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-751
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.1, 0.21.0
>            Reporter: Dick King
>            Assignee: Dick King
>             Fix For: 0.21.0
>
>         Attachments: 2009-08-19--1030.patch, 2009-08-26--1513-patch.patch, 
> mapreduce-751--2009-07-23.patch
>
>
>  We propose a new map/reduce component, rumen, which can be used to process 
> job history logs to produce any or all of the following:
>       * Retrospective info describing the statistical behavior of the
> amount of time it would have taken to launch a job into a certain
> percentage of the number of mapper slots in the log's cluster, given the
> load over the period covered by the log
>       * Statistical info as to the runtimes and shuffle times, etc. of
> the tasks and jobs covered by the log
>       * files describing detailed job trace information, and the
> network topology as inferred from the host locations and rack IDs that
> arise in the job tracker log.  In addition to this facility, rumen
> includes readers for this information to return job and detailed task
> information to other tools.
>         These other tools include a more advanced version of gridmix, and 
> also includes mumak: see blocked issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to