[ https://issues.apache.org/jira/browse/MAPREDUCE-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750947#action_12750947 ]
Hadoop QA commented on MAPREDUCE-318: ------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12418478/mapred-318-3Sep-v1.patch against trunk revision 810505. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 15 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/36/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/36/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/36/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/36/console This message is automatically generated. > Refactor reduce shuffle code > ---------------------------- > > Key: MAPREDUCE-318 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-318 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Reporter: Owen O'Malley > Assignee: Owen O'Malley > Attachments: HADOOP-5233_api.patch, HADOOP-5233_part0.patch, > mapred-318-14Aug.patch, mapred-318-20Aug.patch, mapred-318-24Aug.patch, > mapred-318-3Sep-v1.patch, mapred-318-3Sep.patch, mapred-318-common.patch > > > The reduce shuffle code has become very complex and entangled. I think we > should move it out of ReduceTask and into a separate package > (org.apache.hadoop.mapred.task.reduce). Details to follow. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.