[
https://issues.apache.org/jira/browse/MAPREDUCE-157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755531#action_12755531
]
Sharad Agarwal commented on MAPREDUCE-157:
------------------------------------------
Any reason HistoryEvent interface doesn't have method: public EventCategory
getEventCategory() ? Otherwise there is no point in defining the category enum
in HistoryEvent interface, no ? Also I think getEventType() and enum
EventCategory should be public as events objects are expected to be consumed by
clients in different package. readFields and writeFields can stay non-public as
these would always be used by only EventReader/EventWriter. These should be
kept as non-public in implementations as well.
Otherwise patch looks good to me.
> Job History log file format is not friendly for external tools.
> ---------------------------------------------------------------
>
> Key: MAPREDUCE-157
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-157
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Affects Versions: 0.20.1
> Reporter: Owen O'Malley
> Assignee: Jothi Padmanabhan
> Fix For: 0.21.0
>
> Attachments: mapred-157-10Sep.patch, mapred-157-15Sep-v1.patch,
> mapred-157-15Sep.patch, mapred-157-4Sep.patch, mapred-157-7Sep-v1.patch,
> mapred-157-7Sep.patch, mapred-157-prelim.patch, MAPREDUCE-157-avro.patch,
> MAPREDUCE-157-avro.patch
>
>
> Currently, parsing the job history logs with external tools is very difficult
> because of the format. The most critical problem is that newlines aren't
> escaped in the strings. That makes using tools like grep, sed, and awk very
> tricky.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
