[
https://issues.apache.org/jira/browse/MAPREDUCE-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756035#action_12756035
]
Tom White commented on MAPREDUCE-954:
-------------------------------------
Thanks for posting some code, Arun - makes it easier to follow. A couple of
comments:
* I don't see how MapperImpl is actually used. A user-supplied Mapper extends
Mapper, not MapperImpl, so I'm missing how the concrete context is actually
created.
* The getProgressible() method of JobContext is misspelled - it should be
getProgressable(). (Ironically this is the kind of change that is so difficult
to do with interfaces!)
> The new interface's Context objects should be interfaces
> --------------------------------------------------------
>
> Key: MAPREDUCE-954
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-954
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: client
> Reporter: Owen O'Malley
> Assignee: Arun C Murthy
> Fix For: 0.21.0
>
> Attachments: MAPREDUCE-954.patch, MAPREDUCE-954.patch
>
>
> When I was doing HADOOP-1230, I was persuaded to make the Context objects as
> classes. I think that was a serious mistake. It caused a lot of information
> leakage into the public classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
