[
https://issues.apache.org/jira/browse/MAPREDUCE-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756569#action_12756569
]
Hemanth Yamijala commented on MAPREDUCE-953:
--------------------------------------------
Looked at the test case also. One comment I have is that we should verify the
ACLs, properties and children in a different manner I think. Because right now,
we are constructing the ACLs in the test case using similar code as in the
actual code. This leads to a chance that we could make the same mistake at both
places. I think it may be OK to hardcode what we are verifying, rather than
writing generically. For e.g. we know what the queue configuration is. We know
which queues have what ACLs and what properties, we can hardcode that
verification. That way, the test will be simpler and it will be correct.
For e.g., now because both test and code make the same mistake about the ACL
key, the test doesn't fail, but it doesn't catch the bug as well.
> Generate configuration dump for hierarchial queue configuration
> ---------------------------------------------------------------
>
> Key: MAPREDUCE-953
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-953
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: jobtracker
> Affects Versions: 0.21.0
> Reporter: rahul k singh
> Assignee: V.V.Chaitanya Krishna
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: MAPREDUCE-953-1.patch
>
>
> Generate configuration dump for hierarchial queue configuration
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
