[
https://issues.apache.org/jira/browse/MAPREDUCE-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759079#action_12759079
]
Vinod K V commented on MAPREDUCE-1007:
--------------------------------------
Quickly looked at the patch and tested it on a single node. It works fine. Some
review comments, mostly minor:
- In CapacityTaskScheduler.getJobs(), we can cache the return value from
jobQueuesManager.getJobQueue(queueName) to avoid repetitive lookups.
- Test-cases testSubmitToQueues(), testGetJobs() and the newly added
testJobsForContainerQueues() share a lot of common stuff and test a single
concept - job submission to capacity-scheduler. They can be combined into a
single testJobSubmission(). Further, instead of creating all the internal
queue-related data-structures ourselves, we can simply create a configuration
file and start the scheduler. See
TestRefreshOfQueues.testSuccessfulCapacityRefresh() for an example. You may
need to do some refactoring to facilitate this.
One orthogonal point which this issue may not concern itself with,
jobtracker.jsp is now printing the number of root-queues under a header
'queues'. Just looking at it, it didn't tell me what it actually represents. We
can (1) rename it to root-queues to be clear, or (2) print both root-queues'
and job-queues' number or (3) do away with these numbers altogether and just
give a hyper-link to the queues page. Thoughts?
> MAPREDUCE-777 breaks the UI for hierarchial Queues.
> ----------------------------------------------------
>
> Key: MAPREDUCE-1007
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1007
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Affects Versions: 0.21.0
> Reporter: rahul k singh
> Assignee: V.V.Chaitanya Krishna
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: MAPREDUCE-1007-1.patch, MAPREDUCE-1007.patch
>
>
> MAPREDUCE-777 breaks jobtracker UI for hierarchial queues. When
> jobtracker.jsp is accessed, it throws the following exception:
> {code}
> java.lang.NullPointerException
> at
> org.apache.hadoop.mapred.CapacityTaskScheduler.getJobs(CapacityTaskScheduler.java:1007)
> at
> org.apache.hadoop.mapred.JobTracker.getJobsFromQueue(JobTracker.java:3888)
> at
> org.apache.hadoop.mapred.JobTracker.getQueueInfoArray(JobTracker.java:3869)
> at
> org.apache.hadoop.mapred.JobTracker.getRootQueues(JobTracker.java:3830)
> at
> org.apache.hadoop.mapred.jobtracker_jsp.generateSummaryTable(jobtracker_jsp.java:36)
> ....
> {code}
> (Issue number and the line number in code match - 1007. Some fun for a Hadoop
> developer :) )
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
