[ 
https://issues.apache.org/jira/browse/MAPREDUCE-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782110#action_12782110
 ] 

Matei Zaharia commented on MAPREDUCE-698:
-----------------------------------------

Oops, I forgot to add one other important comment: The new config parameters 
should be documented in the fair scheduler's Forrest documentation in 
src/docs/src/documentation/content/xdocs/fair_scheduler.xml (in the Allocation 
File section). Also, the documentation should say what happens if the maxTasks 
of a pool is set lower than its minTasks: in this case, the maxTasks takes 
precedence. It might also be good to print a warning in PoolManager when 
loading a config file if we see a pool with maxTasks < minTasks. You should do 
this after you finish reading the a <pool> element.

One other very minor thing - there seem to be some tabs in the patch, replace 
them with spaces.

Thanks for taking the time to port this to trunk!

> Per-pool task limits for the fair scheduler
> -------------------------------------------
>
>                 Key: MAPREDUCE-698
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-698
>             Project: Hadoop Map/Reduce
>          Issue Type: New Feature
>          Components: contrib/fair-share
>            Reporter: Matei Zaharia
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-698-prelim.patch, mapreduce-698-trunk.patch, 
> mapreduce-698-trunk.patch
>
>
> The fair scheduler could use a way to cap the share of a given pool similar 
> to MAPREDUCE-532.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to