[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783579#action_12783579
 ] 

Hemanth Yamijala commented on MAPREDUCE-1082:
---------------------------------------------

Have a few comments on this patch:

- I don't know why readFields in JobQueueInfo needs to be overridden. In all 
the API, it is QueueInfo objects that are transferred over IPC, and I think it 
should remain that way.
- I think the test case needs to be an end-to-end test by definition, as the 
fix is both in JobQueueInfo as well as in the JobTracker, where when we 
translate JobQueueInfos to QueueInfos, we fix the translation by walking the 
entire hierarchy. I would suggest a test that brings up a MiniMRCluster with 
hierarchical queues, submits a job to one of the queues and calls 
Cluster.getRootQueues and verifies the returned QueueInfo information. We might 
need a package private JobTracker.setQueueManager to enable setting up 
hierarchical queues with a miniMRCluster.

> Command line UI for queues' information is broken with hierarchical queues.
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1082
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1082
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client, jobtracker
>    Affects Versions: 0.21.0
>            Reporter: Vinod K V
>            Assignee: V.V.Chaitanya Krishna
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1082-1.txt, MAPREDUCE-1082-2.patch
>
>
> When the command "./bin/mapred --config ~/tmp/conf/ queue -list" is run, it 
> just hangs. I can see the following in the JT logs:
> {code}
> 2009-10-08 13:19:26,762 INFO org.apache.hadoop.ipc.Server: IPC Server handler 
> 1 on 55555 caught: java.lang.NullPointerException
>         at org.apache.hadoop.mapreduce.QueueInfo.write(QueueInfo.java:217)
>         at org.apache.hadoop.mapreduce.QueueInfo.write(QueueInfo.java:223)
>         at 
> org.apache.hadoop.io.ObjectWritable.writeObject(ObjectWritable.java:159)
>         at 
> org.apache.hadoop.io.ObjectWritable.writeObject(ObjectWritable.java:126)
>         at org.apache.hadoop.io.ObjectWritable.write(ObjectWritable.java:70)
>         at org.apache.hadoop.ipc.Server.setupResponse(Server.java:1074)
>         at org.apache.hadoop.ipc.Server.access$2400(Server.java:77)
>         at org.apache.hadoop.ipc.Server$Handler.run(Server.java:983)
> {code}
> Same is the case with "./bin/mapred --config ~/tmp/conf/ queue -info 
> <any-container-queue>"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to