[ 
https://issues.apache.org/jira/browse/MAPREDUCE-896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785948#action_12785948
 ] 

Ravi Gummadi commented on MAPREDUCE-896:
----------------------------------------

The new TaskController command is ENABLE_TASK_FOR_CLEANUP.

There is a change in JVMManager where the workdir for the last task was being 
deleted inline, but now we delete it asynchronously. This should be fine.

The change in setupWorkDir fixes the issue of trying to delete workDir, which 
is the current working dir. Only contents of workDir are deleted, leaving the 
workDir as empty. A testcase is added to validate this cleanup of workDir.

Removing check_group as this wouldn't work if user changes the group of workDir.

createFileAndSetPermissions sets a=rx for subDir and file in subDir sothat no 
one can delete them without doing chmod.

Am fine with the other comments.



> Users can set non-writable permissions on temporary files for TT and can 
> abuse disk usage.
> ------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-896
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-896
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tasktracker
>    Affects Versions: 0.21.0
>            Reporter: Vinod K V
>            Assignee: Ravi Gummadi
>             Fix For: 0.21.0
>
>         Attachments: MR-896.patch, MR-896.v1.patch
>
>
> As of now, irrespective of the TaskController in use, TT itself does a full 
> delete on local files created by itself or job tasks. This step, depending 
> upon TT's umask and the permissions set by files by the user, for e.g in 
> job-work/task-work or child.tmp directories, may or may not go through 
> successful completion fully. Thus is left an opportunity for abusing disk 
> space usage either accidentally or intentionally by TT/users.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to