[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786273#action_12786273
 ] 

Konstantin Boudnik commented on MAPREDUCE-1050:
-----------------------------------------------

Well, still fails on my BSD machine. The message is 
{noformat}
TestLostTaskTracker
Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0.791 sec
------------- Standard Output ---------------
2009-12-04 16:43:13,581 INFO  mapred.JobTracker (JobTracker.java:<init>(1334)) 
- Starting jobtracker with owner as cos and supergroup as supergroup
2009-12-04 16:43:13,587 INFO  mapred.JobTracker 
(JobTracker.java:initializeTaskMemoryRelatedConfig(4086)) - Scheduler 
configured with (memSizeForMapSlotOnJT, memSizeForRedu
ceSlotOnJT, limitMaxMemForMapTasks, limitMaxMemForReduceTasks) (-1, -1, -1, -1)
2009-12-04 16:43:13,590 INFO  util.HostsFileReader 
(HostsFileReader.java:refresh(81)) - Refreshing hosts (include/exclude) list
2009-12-04 16:43:13,607 INFO  mapred.QueueConfigurationParser 
(QueueConfigurationParser.java:parseResource(170)) - Bad conf file: top-level 
element not <queues>
------------- ---------------- ---------------

Testcase: testLostTaskTrackerCalledAfterExpiryTime took 0.763 sec
        Caused an ERROR
No queues defined 
java.lang.RuntimeException: No queues defined 
        at 
org.apache.hadoop.mapred.QueueConfigurationParser.parseResource(QueueConfigurationParser.java:171)
        at 
org.apache.hadoop.mapred.QueueConfigurationParser.loadResource(QueueConfigurationParser.java:163)
        at 
org.apache.hadoop.mapred.QueueConfigurationParser.<init>(QueueConfigurationParser.java:92)
        at 
org.apache.hadoop.mapred.QueueManager.getQueueConfigurationParser(QueueManager.java:126)
        at org.apache.hadoop.mapred.QueueManager.<init>(QueueManager.java:146)
        at org.apache.hadoop.mapred.JobTracker.<init>(JobTracker.java:1376)
        at org.apache.hadoop.mapred.JobTracker.<init>(JobTracker.java:1325)
        at 
org.apache.hadoop.mapred.TestLostTaskTracker.setUp(TestLostTaskTracker.java:58)
{noformat}

The other problem: TestLostTaskTracker is JUnit v3 test (it extends TestCase, 
etc.). Please make it to be JUnit v4 (like the other two tests are).

> Introduce a mock object testing framework
> -----------------------------------------
>
>                 Key: MAPREDUCE-1050
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1050
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: MAPREDUCE-1050.patch, MAPREDUCE-1050.patch, 
> MAPREDUCE-1050.patch, MAPREDUCE-1050.patch, MAPREDUCE-1050.patch
>
>
> Using mock objects in unit tests can improve code quality (see e.g. 
> http://www.mockobjects.com/). Hadoop would benefit from having a mock object 
> framework for developers to write unit tests with. Doing so will allow a 
> wider range of failure conditions to be tested and the tests will run faster.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to