[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787433#action_12787433
 ] 

Vinod K V commented on MAPREDUCE-1131:
--------------------------------------


Patch changes look good to me.

One issue with the testcase - because now we are passing an invalid agentlib, 
tasks themselves are failing in the testcase, as can be expected, and so the 
test takes long time to finish (the new testcase itself takes more than 3mins). 
Doing the following makes the test run very fast(~30secs):
{code}
job.setMaxMapAttempts(1);
job.setMaxReduceAttempts(1);
job.setJobSetupCleanupNeeded(false);
{code}
Also, w.r.t {{TestMRJobClient}}, can you please remove the unused import of 
FileNotFoundException and also convert the test into a junit 4 test?

> Using profilers other than hprof can cause JobClient to report job failure
> --------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1131
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1131
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>            Reporter: Aaron Kimball
>            Assignee: Aaron Kimball
>         Attachments: MAPREDUCE-1131.2.patch, MAPREDUCE-1131.3.patch, 
> MAPREDUCE-1131.4.patch, MAPREDUCE-1131.5.patch, MAPREDUCE-1131.patch
>
>
> If task profiling is enabled, the JobClient will download the {{profile.out}} 
> file created by the tasks under profile. If this causes an IOException, the 
> job is reported as a failure to the client, even though all the tasks 
> themselves may complete successfully. The expected result files are assumed 
> to be generated by hprof. Using the profiling system with other profilers 
> will cause job failure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to